zhijiangW opened a new pull request #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull URL: https://github.com/apache/flink/pull/10840 ## What is the purpose of the change *The current component `AbstractInvokable` in `CheckpointBarrierHandler` is annotated as `@Nullable`. Actually in real code path it is passed via the constructor and never be null. The nullable annotation is only used for unit test purpose. But this way would mislead the real usage in practice and bring extra troubles, because you have to alway check whether it is null before usage in related processes.* *We can refactor the related unit tests to implement a dummy `AbstractInvokable` for tests and remove the @Nullable annotation from the related class constructors.* ## Brief change log - *Remove `Nullable` annotation from `CheckpointedInputGate`* - *Remove `Nullable` annotation from `CheckpointBarrierHandler`* - *Introduce `DummyCheckpointInvokable` for tests* ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
