[GitHub] [flink] zhuzhurk commented on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

2021-01-10 Thread GitBox
zhuzhurk commented on pull request #14579: URL: https://github.com/apache/flink/pull/14579#issuecomment-757510492 The commit to deprecate `InputDependencyConstraint` looks good to me. This is an automated message from the

[GitHub] [flink] zhuzhurk commented on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

2021-01-09 Thread GitBox
zhuzhurk commented on pull request #14579: URL: https://github.com/apache/flink/pull/14579#issuecomment-756622002 I think you are right. It would be better to annotate the methods as `@Deprecated` first and remove it in future versions.

[GitHub] [flink] zhuzhurk commented on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

2021-01-08 Thread GitBox
zhuzhurk commented on pull request #14579: URL: https://github.com/apache/flink/pull/14579#issuecomment-756622002 I think you are right. It would be better to annotate the methods as `@Deprecated` first and remove it in future versions.

[GitHub] [flink] zhuzhurk commented on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

2021-01-07 Thread GitBox
zhuzhurk commented on pull request #14579: URL: https://github.com/apache/flink/pull/14579#issuecomment-756533725 There is a test failure in python module. "FAILED pyflink/common/tests/test_execution_config.py::ExecutionConfigTests::test_get_set_default_input_dependency_constraint"