[GitHub] [flink] zjureel commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

2022-02-08 Thread GitBox
zjureel commented on pull request #18490: URL: https://github.com/apache/flink/pull/18490#issuecomment-1033300250 > No, the 'area.freeMemory' will call `LazyMemorySegmentPool.returnPage` and return the allocated `MemorySegment` to `LazyMemorySegmentPool.cachePages` only and won't f

[GitHub] [flink] zjureel commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

2022-01-25 Thread GitBox
zjureel commented on pull request #18490: URL: https://github.com/apache/flink/pull/18490#issuecomment-1020749306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink] zjureel commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

2022-01-25 Thread GitBox
zjureel commented on pull request #18490: URL: https://github.com/apache/flink/pull/18490#issuecomment-1020930174 Thanks @JingsongLi , I think I miss the operations in `MemoryManager` :( And another issue is in `BinaryHashTableTest.testBinaryHashBucketAreaNotEnoughMem`, there's no `tabl

[GitHub] [flink] zjureel commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

2022-01-24 Thread GitBox
zjureel commented on pull request #18490: URL: https://github.com/apache/flink/pull/18490#issuecomment-1020749306 Hello @KarmaGYZ @JingsongLi , could you help to review this issue when you're free? -- This is an automated message from the Apache Git Service. To respond to the message, pl