[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #70: [FLINK-31772] Adjusting Kinesis Ratelimiting strategy to fix performance regression

2023-04-26 Thread via GitHub
dannycranmer commented on code in PR #70: URL: https://github.com/apache/flink-connector-aws/pull/70#discussion_r1177504112 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java: ## @@ -144,6 +150,8 @@

[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #70: [FLINK-31772] Adjusting Kinesis Ratelimiting strategy to fix performance regression

2023-04-26 Thread via GitHub
dannycranmer commented on code in PR #70: URL: https://github.com/apache/flink-connector-aws/pull/70#discussion_r1177501504 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java: ## @@ -144,6 +150,8 @@

[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #70: [FLINK-31772] Adjusting Kinesis Ratelimiting strategy to fix performance regression

2023-04-24 Thread via GitHub
dannycranmer commented on code in PR #70: URL: https://github.com/apache/flink-connector-aws/pull/70#discussion_r1175081394 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java: ## @@ -144,6 +150,8 @@