[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-15 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1231704047 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/testutils/tables/TableBuilder.java: ## @@ -51,4 +52,8 @@ private static TableField cre

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-08 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1222721429 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialectTypeTest.java: ## @@ -0,0 +1,41 @@ +pack

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-07 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1221555134 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialectTypeTest.java: ## @@ -0,0 +1,41 @@ +pack

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-07 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1221509236 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialectTypeTest.java: ## @@ -0,0 +1,41 @@ +pack

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-07 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1221506906 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialectTypeTest.java: ## @@ -0,0 +1,41 @@ +pack

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-07 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1221252967 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialectTypeTest.java: ## @@ -0,0 +1,41 @@ +pack

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-07 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1221252647 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialectTypeTest.java: ## @@ -0,0 +1,41 @@ +pack

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-05 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1218281097 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialect.java: ## @@ -0,0 +1,78 @@ +package org.apache.fli

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-05 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1218280732 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialect.java: ## @@ -0,0 +1,78 @@ +package org.apache.fli

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-05 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1218215385 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseRowConvert.java: ## @@ -0,0 +1,85 @@ +package o

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1212587682 ## flink-connector-jdbc/pom.xml: ## @@ -194,6 +194,22 @@ under the License. test + +

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1212587682 ## flink-connector-jdbc/pom.xml: ## @@ -194,6 +194,22 @@ under the License. test + +

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1211723597 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSinkITCase.java: ## @@ -322,6 +325,9 @@ void testBatchSink() thr

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1211584622 ## flink-connector-jdbc/pom.xml: ## @@ -194,6 +194,22 @@ under the License. test + +

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1211582778 ## flink-connector-jdbc/pom.xml: ## @@ -194,6 +194,22 @@ under the License. test + +

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1211581006 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSinkITCase.java: ## @@ -322,6 +325,9 @@ void testBatchSink() thr

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-30 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1210434972 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/clickhouse/table/ClickhouseTableRow.java: ## @@ -0,0 +1,35 @@ +package org.a

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-30 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1210434972 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/clickhouse/table/ClickhouseTableRow.java: ## @@ -0,0 +1,35 @@ +package org.a

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-30 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1210426185 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSinkITCase.java: ## @@ -322,6 +325,9 @@ void testBatchSink() thr

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-30 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1210383231 ## flink-connector-jdbc/pom.xml: ## @@ -194,6 +194,22 @@ under the License. test + +

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-30 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1210380038 ## flink-connector-jdbc/pom.xml: ## @@ -194,6 +194,22 @@ under the License. test + +

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-30 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1210360121 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/clickhouse/table/ClickhouseTableRow.java: ## @@ -0,0 +1,35 @@ +package org.a