[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #12: [FLINK-27940] Migrate tests to junit5

eskabetxe commented on code in PR #12: URL: https://github.com/apache/flink-connector-jdbc/pull/12#discussion_r1055537648 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/dialect/sqlserver/SqlServerPreparedStatementTest.java: ## @@ -26,7 +26,7 @@ import st

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #12: [FLINK-27940] Migrate tests to junit5

eskabetxe commented on code in PR #12: URL: https://github.com/apache/flink-connector-jdbc/pull/12#discussion_r1055537648 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/dialect/sqlserver/SqlServerPreparedStatementTest.java: ## @@ -26,7 +26,7 @@ import st

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #12: [FLINK-27940] Migrate tests to junit5

eskabetxe commented on code in PR #12: URL: https://github.com/apache/flink-connector-jdbc/pull/12#discussion_r1055536159 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/dialect/sqlserver/SqlServerTableSinkITCase.java: ## @@ -81,9 +86,8 @@ public class Sql

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #12: [FLINK-27940] Migrate tests to junit5

eskabetxe commented on code in PR #12: URL: https://github.com/apache/flink-connector-jdbc/pull/12#discussion_r1055536159 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/dialect/sqlserver/SqlServerTableSinkITCase.java: ## @@ -81,9 +86,8 @@ public class Sql

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #12: [FLINK-27940] Migrate tests to junit5

eskabetxe commented on code in PR #12: URL: https://github.com/apache/flink-connector-jdbc/pull/12#discussion_r1055534726 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/catalog/MySqlCatalogTestBase.java: ## @@ -140,10 +140,18 @@ public static void beforeA

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #12: [FLINK-27940] Migrate tests to junit5

eskabetxe commented on code in PR #12: URL: https://github.com/apache/flink-connector-jdbc/pull/12#discussion_r1055532277 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkMigrationTest.java: ## @@ -77,7 +79,8 @@ public JdbcXaSinkMigrationTest(F

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #12: [FLINK-27940] Migrate tests to junit5

eskabetxe commented on code in PR #12: URL: https://github.com/apache/flink-connector-jdbc/pull/12#discussion_r1053484871 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkMigrationTest.java: ## @@ -77,7 +79,8 @@ public JdbcXaSinkMigrationTest(F