matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1573891656
Thank you all involved in the PR and for all the iterations!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1564380946
@MartijnVisser @snuyanzin I've rebased again, can you please run ci again?
It would be great to merge it if everything passes, thx.
--
This is an automated message from the A
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1561465152
thx @snuyanzin, excluded the `jna` dependency from `crate-jdbc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1561417404
> do we need crate's dependency on jna or can we exclude it?
We can exclude it.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1561343935
Any hints? locally I don't get such error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1561018315
Asked because I see that jobs are cancelled:
https://github.com/apache/flink-connector-jdbc/actions/runs/5068186731/jobs/9100199661?pr=29#step:13:347
--
This is an automated me
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1561006427
apologies, I think you need to rerun the CI as I've pushed one more commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1560942386
@MartijnVisser done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1522922001
@eskabetxe Could you take a look to finish up this PR please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1497404438
Merged master and fixed timestamp related tests by using `UTC` timezone for
the container and the tests.
--
This is an automated message from the Apache Git Service.
To respond
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1497290428
Checking the test failure because of different Timezone (UTC vs
Europe/Athens that I have locally)
--
This is an automated message from the Apache Git Service.
To respond to th
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1495660925
@eskabetxe FYI, I've found a trick to choose the `CrateDBDialect` based on
the `jdbc:crate://` url provided by the user, but internally change it to
`jdbc:postgresql://` and ther
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1491509754
@eskabetxe When you have the time, please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1488565147
Apologies for the review requests.
I thought it was some github hiccup, but I apparently I cannot ask for
re-review from both?
--
This is an automated message from the Apach
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1485352867
Thx a lot both of you for the review.
I'll try to address the comments soon and ask for another round.
@eskabetxe True, CrateDB is very similar in connectivity with Postg
matriv commented on PR #29:
URL:
https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1484236669
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
16 matches
Mail list logo
