chucheng92 commented on code in PR #10:
URL:
https://github.com/apache/flink-connector-kafka/pull/10#discussion_r1152677881
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaCommittableSerializer.java:
##########
@@ -46,6 +46,15 @@ public byte[] serialize(KafkaCommittable state) throws
IOException {
@Override
public KafkaCommittable deserialize(int version, byte[] serialized) throws
IOException {
+ switch (version) {
+ case 1:
Review Comment:
@tzulitai hi, Gordon. thanks for your reviewing! the version from 1 can be
found at
https://github.com/apache/flink/pull/16676/files#diff-decc6e90291b6f7c78efae7bd3223d218a1aba00bbbf53e4c696d63506e907cf.
however, we can't always check PR to see if there is an old version or a
version change. So I agree with you to add JavaDocs to record serialized
version evolutions. I added it in the pr. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
