subject:"\[GitHub\] \[flink\-connector\-kafka\] tzulitai commented on pull request #7\: \[FLINK\-31408\] Add support for EOS delivery\-guarantee in upsert\-kafka"

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #7: [FLINK-31408] Add support for EOS delivery-guarantee in upsert-kafka

2023-07-11 Thread via GitHub

tzulitai commented on PR #7: URL: https://github.com/apache/flink-connector-kafka/pull/7#issuecomment-1630767966 @Ge as discussed offline, I think there really isn't a better way around the current PR approach. I'll address the comments on the doc and proceed to merge this. Than

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #7: [FLINK-31408] Add support for EOS delivery-guarantee in upsert-kafka

2023-03-27 Thread via GitHub

tzulitai commented on PR #7: URL: https://github.com/apache/flink-connector-kafka/pull/7#issuecomment-1486051189 hey @Ge, thanks for opening this PR! In addition to these changes, I think we have to let `ReducingUpsertSink` implement `TwoPhaseCommittingSink` as well. Expla