lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1432241594
@reta I guess I did something wrong with my repo; I made a minor change in
the comments, so I wanted to squish the commits and force push. I did rebase, I
thought, again
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1432248031
I think I can do it in github:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork
--
This is an automated mess
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1432262966
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1432300172
@reta Did all the changes you suggested, also ran the mvn spotless:apply .
Btw., my IntelliJ showed a list of warnings in places not relevant to my
changes. Even one e
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1432341333
The error is about this line:
* @param bulkProcessorBuilderFactory configuring the {@link
BulkProcessor}'s builder
Apparently that parameter is no longer p
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1432357173
Sure.
I will fix that bulkProcessorBuilderFactory thing, everything else is less
important at the moment. I got that list of warnings while committing. When I
just
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1433472225
@reta I fixed some warnings, pushed as a separate commit, so you can review.
Now looking at the tests. We need to somehow simulate the Opensearch server
that can get t
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1433647197
@reta Trying to add the test. For some reason the tests from
OpensearchWriterITCase class are not executed at all.
I run the command:
mvn clean test
in f
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1433675182
Thanks @reta . One more step. It looks like I need to have a "valid Docker
environment". I install the docker things:
sudo apt-get install docker-ce docker-ce-cli
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1433883642
@reta I installed docker, the daemon is running, the hello world test worked.
However, the 'mvn verify' still fails with "OpensearchSinkITCase ยป
IllegalState Could not
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1434732687
@reta Added the test. I think now it is good.
I also tested the test itself, by simulating the "bad" handler, making the
test fail, just to make sure it checks it prop
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1434889977
@reta I committed the changes you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1624155784
I see since I finalized this request there were some other changes in main
branch, and so there are conflicts.
I am going to rebase my branch and hopefully resolve the
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1624279183
I actually resolved the conflicts in the web editor, and updated my branch.
Can somebody review this?
--
This is an automated message from the Apache Git Service.
T
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1624353999
Actually, hold on for now. I was not able to compile it in my work
environment, now tried in my home desktop and found some errors. Let me fix
them. Will let you know.
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1624412993
I made it clean now, you can review and maybe merge already.
I got the latest from apache:main branch and re-applied all my changes on
top of it, so you can see now it
lilyevsky commented on PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1625707386
So you can merge it now?
After you do, I am going to build locally the latest version and do my own
tests.
--
This is an automated message from the Apache Git Servi
17 matches
Mail list logo
