reta commented on PR #5:
URL:
https://github.com/apache/flink-connector-opensearch/pull/5#issuecomment-1489036967
> I am reluctant to introduce a new Sink API based on the internal
implementation unless there is a really good/semantic reason.
Thanks @dannycranmer , I understand your
reta commented on PR #5:
URL:
https://github.com/apache/flink-connector-opensearch/pull/5#issuecomment-1487055907
@dannycranmer would appreciate if you could take a look, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
reta commented on PR #5:
URL:
https://github.com/apache/flink-connector-opensearch/pull/5#issuecomment-1453764023
Thanks a lot for review @dannycranmer
> @reta The PR looks good to me minus the Mockito comment. However I have
questions over the approach here. We are adding a new
reta commented on PR #5:
URL:
https://github.com/apache/flink-connector-opensearch/pull/5#issuecomment-1426283511
Thanks @dannycranmer , I think I went through all your comments, thanks a
lot, really appreciate it.
--
This is an automated message from the Apache Git Service.
To respond
reta commented on PR #5:
URL:
https://github.com/apache/flink-connector-opensearch/pull/5#issuecomment-1422727255
Thanks a lot for the review @hlteoh37 , I believe I addressed or/and
answered all your comments, please let me know if I missed something
--
This is an automated message
reta commented on PR #5:
URL:
https://github.com/apache/flink-connector-opensearch/pull/5#issuecomment-1419405403
@zentol @MartijnVisser doing my one per month ping diligence :-), please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
reta commented on PR #5:
URL:
https://github.com/apache/flink-connector-opensearch/pull/5#issuecomment-137051
@zentol @MartijnVisser would appreciate if you guys have time for the
review, adding AsyncSink support for OpenSearch, discussed initially [1]
[1]
