tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537065990
@nlu90 No luck - Pulsar patch release breaks interface:
```
Error: COMPILATION ERROR :
[INFO] -
Er
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537068806
Change to builder which is a compatible way - test compile from 2.10.1 to
2.10.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537071088
Werid. I run already `mvn spotless:apply` and no diff report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537071531
Emm...It seems that plugin is default to skip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537073378
@reswqa I manually disable skip. But the default config seems:
```
com.diffplug.spotless
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537078809
Still a few breaking things.
I'm trying to pick https://github.com/apache/flink/pull/21204.
--
This is an automated message from the Apache Git Service.
To respond to
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537091245
I'm feeling lucky now ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537095518
Pending for merging...
Although, I suggest a release is required to deliver this fix to downstream
users.
cc @MartijnVisser @leonardBang @dannycranmer what do yo
