[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #274: [FLINK-28180] Unify Application and SessionJob reconciler logic

2022-06-27 Thread GitBox
gyfora commented on code in PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#discussion_r907193815 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ## @@ -0,0 +1

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #274: [FLINK-28180] Unify Application and SessionJob reconciler logic

2022-06-27 Thread GitBox
gyfora commented on code in PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#discussion_r907153684 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ## @@ -0,0 +1

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #274: [FLINK-28180] Unify Application and SessionJob reconciler logic

2022-06-26 Thread GitBox
gyfora commented on code in PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#discussion_r906772317 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/FlinkReconciler.java: ## @@ -0,0 +1,282 @@ +/* + *

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #274: [FLINK-28180] Unify Application and SessionJob reconciler logic

2022-06-26 Thread GitBox
gyfora commented on code in PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#discussion_r906772181 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/FlinkReconciler.java: ## @@ -0,0 +1,282 @@ +/* + *

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #274: [FLINK-28180] Unify Application and SessionJob reconciler logic

2022-06-26 Thread GitBox
gyfora commented on code in PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#discussion_r906772118 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/FlinkReconciler.java: ## @@ -0,0 +1,282 @@ +/* + *