gyfora commented on PR #252:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1145749943
@Miuler could you please provide a detailed description of what this change
does specifically and what is the error scenario that we are handling here?
This is a ver
gyfora commented on PR #252:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1145773156
In addition I would like to kindly ask you to not include any refactorings
with this fix initially. This will help us understand the problem your solution
better.
A
gyfora commented on PR #252:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1145898541
Do you have a yaml that I can use to reproduce this? I am still not
convinced that we need to refactor etc
--
This is an automated message from the Apache Git Service.
T
gyfora commented on PR #252:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1145900109
And please don’t get me wrong, all I am trying to do is keep this as simple
as possible :) I have already spent quite a lot of time simplifying these
methods and the flow
gyfora commented on PR #252:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1145936781
@Miuler i will take a look later tonight to see what is the minimal fix that
we need. Then we can discuss if we want to refactor the cancel in a separate
ticket maybe
-
gyfora commented on PR #252:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1146109215
@Miuler I looked into this a little and this is the only thing we need to
change for this to work (and make your test to pass):
```
diff --git
a/flink-kubernetes
gyfora commented on PR #252:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1146654972
Merged this to main manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
