[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #274: [FLINK-28180] Unify Application and SessionJob reconciler logic

2022-06-27 Thread GitBox
gyfora commented on PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#issuecomment-1167041418 If no more comments @Aitozi I will merge this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #274: [FLINK-28180] Unify Application and SessionJob reconciler logic

2022-06-26 Thread GitBox
gyfora commented on PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#issuecomment-1166444887 @Aitozi added some further javadocs to clean up the base reconciler class and renamed classes for consistency. Please take a look -- This is an automated message from t

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #274: [FLINK-28180] Unify Application and SessionJob reconciler logic

2022-06-25 Thread GitBox
gyfora commented on PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#issuecomment-1166364561 @Aitozi thanks for the review, I have managed to move further methods into the `FlinkReconciler` and make the subclass implementations a little more modular with new metho

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #274: [FLINK-28180] Unify Application and SessionJob reconciler logic

2022-06-24 Thread GitBox
gyfora commented on PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#issuecomment-1165465785 Cc @morhidi @wangyang0918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #274: [FLINK-28180] Unify Application and SessionJob reconciler logic

2022-06-22 Thread GitBox
gyfora commented on PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#issuecomment-1162750385 cc @Aitozi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co