[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #351: [FLINK-28646] Handle scaling operation separately in reconciler/service

2022-08-25 Thread GitBox
morhidi commented on code in PR #351: URL: https://github.com/apache/flink-kubernetes-operator/pull/351#discussion_r955084321 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ## @@ -122,1

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #351: [FLINK-28646] Handle scaling operation separately in reconciler/service

2022-08-25 Thread GitBox
morhidi commented on code in PR #351: URL: https://github.com/apache/flink-kubernetes-operator/pull/351#discussion_r955077692 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/diff/SpecDiffTest.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #351: [FLINK-28646] Handle scaling operation separately in reconciler/service

2022-08-25 Thread GitBox
morhidi commented on code in PR #351: URL: https://github.com/apache/flink-kubernetes-operator/pull/351#discussion_r955077692 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/diff/SpecDiffTest.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #351: [FLINK-28646] Handle scaling operation separately in reconciler/service

2022-08-25 Thread GitBox
morhidi commented on code in PR #351: URL: https://github.com/apache/flink-kubernetes-operator/pull/351#discussion_r955074814 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/diff/SpecDiffTest.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed