coderappee commented on PR #109: URL: https://github.com/apache/flink-ml/pull/109#issuecomment-1156647134
> Hi @coderappee , thanks for creating this PR. Could you please illustrate why do we need to add these static imports? For now the test cases can still pass without these imports. Ok, I understand that why I can not build the project and pass the test cases now, because I use the latest code of flink master and do not use flink version 1.15.0. In or before flink version 1.15.0, AbstractTestBase is extended from TestBaseUtils, so any class extends from AbstractTestBase can use the static method of TestBaseUtils(compareResultCollections is one of the static method of it) But after [FLINK-27454], the AbstractTestBase does not extend from TestBaseUtils any more. It exteneds from TestLogger and can not use those static methods without static import. Ok it depends whether we close this pr or not, since if we migrate or upgrade flink version newer than 1.15.0, we still need to static import that method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
