yunfengzhou-hub commented on code in PR #156:
URL: https://github.com/apache/flink-ml/pull/156#discussion_r1007512230
##
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java:
##
@@ -47,10 +47,16 @@
/**
* A Transformer which combines a
yunfengzhou-hub commented on code in PR #156:
URL: https://github.com/apache/flink-ml/pull/156#discussion_r1015280099
##
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java:
##
@@ -74,64 +85,107 @@ public Table[] transform(Table... inputs)
yunfengzhou-hub commented on code in PR #156:
URL: https://github.com/apache/flink-ml/pull/156#discussion_r978291706
##
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssemblerParams.java:
##
@@ -21,11 +21,31 @@
import org.apache.flink.ml.common.pa
yunfengzhou-hub commented on code in PR #156:
URL: https://github.com/apache/flink-ml/pull/156#discussion_r984140802
##
docs/content/docs/operators/feature/vectorassembler.md:
##
@@ -27,8 +27,10 @@ under the License.
Review Comment:
I found that `VectorSizeHint` is also us
yunfengzhou-hub commented on code in PR #156:
URL: https://github.com/apache/flink-ml/pull/156#discussion_r990872536
##
docs/content/docs/operators/feature/vectorassembler.md:
##
@@ -156,12 +160,13 @@ input_data_table = t_env.from_data_stream(
[DenseVectorTypeInfo()
yunfengzhou-hub commented on code in PR #156:
URL: https://github.com/apache/flink-ml/pull/156#discussion_r991744425
##
flink-ml-python/pyflink/ml/lib/feature/vectorassembler.py:
##
@@ -31,17 +33,38 @@ class _VectorAssemblerParams(
Params for :class:`VectorAssembler`.
yunfengzhou-hub commented on code in PR #156:
URL: https://github.com/apache/flink-ml/pull/156#discussion_r992901815
##
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssemblerParams.java:
##
@@ -21,11 +21,29 @@
import org.apache.flink.ml.common.pa
