[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #422: [FLINK-30294] Change table property key 'log.scan' to 'startup.mode' and add a default startup mode in Table Store

[GitBox]

JingsongLi commented on code in PR #422:
URL: https://github.com/apache/flink-table-store/pull/422#discussion_r1040392229


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java:
##########
@@ -327,16 +327,18 @@ public class CoreOptions implements Serializable {
                             "The field that generates the sequence number for 
primary key table,"
                                     + " the sequence number determines which 
data is the most recent.");
 
-    public static final ConfigOption<LogStartupMode> LOG_SCAN =
-            ConfigOptions.key("log.scan")
-                    .enumType(LogStartupMode.class)
-                    .defaultValue(LogStartupMode.FULL)
+    public static final ConfigOption<StartupMode> STARTUP_MODE =
+            ConfigOptions.key("startup.mode")

Review Comment:
   `scan.mode`?



##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java:
##########
@@ -327,16 +327,18 @@ public class CoreOptions implements Serializable {
                             "The field that generates the sequence number for 
primary key table,"
                                     + " the sequence number determines which 
data is the most recent.");
 
-    public static final ConfigOption<LogStartupMode> LOG_SCAN =
-            ConfigOptions.key("log.scan")
-                    .enumType(LogStartupMode.class)
-                    .defaultValue(LogStartupMode.FULL)
+    public static final ConfigOption<StartupMode> STARTUP_MODE =
+            ConfigOptions.key("startup.mode")
+                    .enumType(StartupMode.class)
+                    .defaultValue(StartupMode.DEFAULT)
+                    .withDeprecatedKeys("log.scan")
                     .withDescription("Specify the startup mode for log 
consumer.");
 
-    public static final ConfigOption<Long> LOG_SCAN_TIMESTAMP_MILLS =
-            ConfigOptions.key("log.scan.timestamp-millis")
+    public static final ConfigOption<Long> STARTUP_TIMESTAMP_MILLIS =
+            ConfigOptions.key("startup.timestamp-millis")

Review Comment:
   `scan.timestamp-mills`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org