[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #540: [FLINK-31087] Introduce insert-changes action

JingsongLi commented on code in PR #540: URL: https://github.com/apache/flink-table-store/pull/540#discussion_r1109562277 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/types/DataTypeCasts.java: ## @@ -57,23 +57,31 @@ public final class DataTypeCasts {

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #540: [FLINK-31087] Introduce insert-changes action

JingsongLi commented on code in PR #540: URL: https://github.com/apache/flink-table-store/pull/540#discussion_r1109369372 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/action/ActionBase.java: ## @@ -61,4 +93,48 @@ public abstract class Actio

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #540: [FLINK-31087] Introduce insert-changes action

JingsongLi commented on code in PR #540: URL: https://github.com/apache/flink-table-store/pull/540#discussion_r1108233513 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/action/InsertChangesAction.java: ## @@ -0,0 +1,192 @@ +/* + * Licensed to

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #540: [FLINK-31087] Introduce insert-changes action

JingsongLi commented on code in PR #540: URL: https://github.com/apache/flink-table-store/pull/540#discussion_r1108235271 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/action/InsertChangesAction.java: ## @@ -0,0 +1,192 @@ +/* + * Licensed to

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #540: [FLINK-31087] Introduce insert-changes action

JingsongLi commented on code in PR #540: URL: https://github.com/apache/flink-table-store/pull/540#discussion_r1108233048 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/action/InsertChangesAction.java: ## @@ -0,0 +1,192 @@ +/* + * Licensed to

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #540: [FLINK-31087] Introduce insert-changes action

JingsongLi commented on code in PR #540: URL: https://github.com/apache/flink-table-store/pull/540#discussion_r1108219002 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/action/InsertChangesAction.java: ## @@ -0,0 +1,192 @@ +/* + * Licensed to

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #540: [FLINK-31087] Introduce insert-changes action

JingsongLi commented on code in PR #540: URL: https://github.com/apache/flink-table-store/pull/540#discussion_r1108217172 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/action/DeleteAction.java: ## @@ -115,8 +110,7 @@ public void run() throws

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #540: [FLINK-31087] Introduce insert-changes action

JingsongLi commented on code in PR #540: URL: https://github.com/apache/flink-table-store/pull/540#discussion_r1108217172 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/action/DeleteAction.java: ## @@ -115,8 +110,7 @@ public void run() throws