[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #136: [FLINK-27752] Change 'path' to 'root-path' in table store

2022-05-24 Thread GitBox
LadyForest commented on code in PR #136: URL: https://github.com/apache/flink-table-store/pull/136#discussion_r881192269 ## flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/TableStoreManagedFactoryTest.java: ## @@ -355,4 +380,42 @@ private static

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #136: [FLINK-27752] Change 'path' to 'root-path' in table store

2022-05-24 Thread GitBox
LadyForest commented on code in PR #136: URL: https://github.com/apache/flink-table-store/pull/136#discussion_r881189824 ## flink-table-store-kafka/src/main/java/org/apache/flink/table/store/kafka/KafkaLogStoreFactory.java: ## @@ -93,6 +96,23 @@ public Set> optionalOptions() {