[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #395: [FLINK-30125] Projection pushdown is not work for partial update

2022-11-22 Thread GitBox
SteNicholas commented on code in PR #395: URL: https://github.com/apache/flink-table-store/pull/395#discussion_r1030044691 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/DeduplicateMergeFunction.java: ## @@ -48,8 +48,17 @@ public

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #395: [FLINK-30125] Projection pushdown is not work for partial update

2022-11-22 Thread GitBox
SteNicholas commented on code in PR #395: URL: https://github.com/apache/flink-table-store/pull/395#discussion_r1030044159 ## flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/PreAggregationITCase.java: ## @@ -711,6 +710,10 @@ public void

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #395: [FLINK-30125] Projection pushdown is not work for partial update

2022-11-22 Thread GitBox
SteNicholas commented on code in PR #395: URL: https://github.com/apache/flink-table-store/pull/395#discussion_r1030043673 ## flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/PartialUpdateITCase.java: ## @@ -65,8 +65,10 @@ public void