[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-18 Thread GitBox
tsreaper commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r876524803 ## flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/AggregationITCase.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache S

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-19 Thread GitBox
tsreaper commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r876537585 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreImpl.java: ## @@ -201,17 +204,28 @@ public static FileStoreImpl createWithPri

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-19 Thread GitBox
tsreaper commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r877715115 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/AggregateFunction.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-19 Thread GitBox
tsreaper commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r877715408 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreImpl.java: ## @@ -201,17 +204,28 @@ public static FileStoreImpl createWithPri

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-20 Thread GitBox
tsreaper commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r877680927 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/AggregationMergeFunction.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-27 Thread GitBox
tsreaper commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r883447651 ## docs/content/docs/development/create-table.md: ## @@ -268,3 +268,39 @@ For example, the inputs: Output: - <1, 25.2, 20, 'This is a book'> + +## Aggregat

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-29 Thread GitBox
tsreaper commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r884370488 ## flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/AggregationITCase.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-31 Thread GitBox
tsreaper commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r885565159 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/AggregateMergeFunction.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed t