[GitHub] flink issue #2032: [FLINK-3965] [gelly] Delegating GraphAlgorithm

2016-06-30 Thread vasia
Github user vasia commented on the issue: https://github.com/apache/flink/pull/2032 I've had an offline discussion with @greghogan about this. We won't be advertising `DelegatingGraphAlgorithm` as a user-facing feature. +1 from me! --- If your project is set up for it, you can reply

[GitHub] flink issue #2032: [FLINK-3965] [gelly] Delegating GraphAlgorithm

2016-06-22 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2032 Hi @vasia, Configurations can be merged if there exists a configuration which satisfies all configuration constraints. It is left to the algorithm to decide whether and how to merged the v

[GitHub] flink issue #2032: [FLINK-3965] [gelly] Delegating GraphAlgorithm

2016-06-10 Thread vasia
Github user vasia commented on the issue: https://github.com/apache/flink/pull/2032 Hi, I don't completely get the reasoning either, but it sounds interesting indeed! @greghogan, could you maybe clarify the following for me: - What do you mean by "mergeable" configuration?

[GitHub] flink issue #2032: [FLINK-3965] [gelly] Delegating GraphAlgorithm

2016-06-07 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2032 I see no problem with merging this, from a code perspective. I do not completely get all the mechanics and reasoning behind this, so would be great if @vasia could comment on this. ---

[GitHub] flink issue #2032: [FLINK-3965] [gelly] Delegating GraphAlgorithm

2016-06-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2032 @StephanEwen do you think this is a good and proper strategy? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no