[GitHub] flink issue #2102: [FLINK-4068] [tableAPI] Move constant computations out of...

2016-09-08 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2102 As I mentioned above, the `cannot translate call AS($t0, $t1)` error because of a Calcite bug. The [CALCITE-1297](https://issues.apache.org/jira/browse/CALCITE-1297) fixed it , but not yet released.

[GitHub] flink issue #2102: [FLINK-4068] [tableAPI] Move constant computations out of...

2016-08-29 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2102 Thanks @twalthr . This issue is more complex than I expected before. I will try to update this PR in next days. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2102: [FLINK-4068] [tableAPI] Move constant computations out of...

2016-08-29 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2102 @wuchong I have added symbols recently. So functions like `TRIM` are now called correctly. If you like you could update this PR. --- If your project is set up for it, you can reply to this email and

[GitHub] flink issue #2102: [FLINK-4068] [tableAPI] Move constant computations out of...

2016-06-17 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2102 @twalthr That sounds great ! Thank you . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] flink issue #2102: [FLINK-4068] [tableAPI] Move constant computations out of...

2016-06-17 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2102 Regarding 3.: I already have some code in a branch that introduces symbols instead of the "Integer hack" we are currently using, but I haven't finished it so far. I can solve this issue for you. --

[GitHub] flink issue #2102: [FLINK-4068] [tableAPI] Move constant computations out of...

2016-06-16 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2102 After introducing `RexExecutor` which make `ReduceExpressionRules` taking effect , many errors occurred. 1. The `cannot translate call AS($t0, $t1)` is a Calcite bug I think, and I create

[GitHub] flink issue #2102: [FLINK-4068] [tableAPI] Move constant computations out of...

2016-06-15 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2102 This @wuchong, your approach looks good. I also found that the `ReduceExpressionRules` had no effect due to the missing `RexExecutor`. However, it seems that several tests of `ExpressionITCa

[GitHub] flink issue #2102: [FLINK-4068] [tableAPI] Move constant computations out of...

2016-06-15 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2102 Thanks for the PR @wuchong! I will have a look at it soon :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not