[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-11 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2177 All the container* config keys are now renamed to `containerized.`, so we have `yarn.` and `containerized.` as prefixes. But these config keys will be undocumented for now. In the documentation,

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-07 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2177 Yeah, then let's leave them as they were since we don't know yet what mesos will require there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-07 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2177 But with this argument, it would be even better to leave the configuration parameters as they are in 1.0 until we are 100% certain that mesos needs a similar mechanism. --- If your project is set

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-07 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2177 So you are suggesting to use the heap cutoff also for the JVM started in standalone mode? The cutoff was introduced for YARN because there is a difference in the amount of used memory for a cont

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-07 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2177 My thinking was that Mesos maybe didn't require this, yes. Having it for Yarn only makes for a better user experience right now. So we could leave it under the "container" namespace. --- If your p

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-07 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2177 Sorry for chiming in late, but can't - `heap-cutoff-ratio` and `heap-cutoff-min` be general parameters that apply to all VMs we start? Same for `master.env.*` and `taskmanager.env.*`. Should

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-07 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2177 I'll rename `containerized` to `container` once I got a third confirmation from a committer on this issue. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-05 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2177 I think it's a good idea to merge `container` and `containerized`. I think the idea is to introduce some general container parameters, such as the `heap-cutoff-ratio`, which are valid n

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2177 There are a lot of config options that seem to exist in two variants: One for standalone setup, one for containered setup. Why are we making this distinction? --- If your project is set

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2177 That would be good to address. Can we get away with only `yarn.` and `taskmanager.`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-04 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2177 The YARN settings are now spread across three prefixes: - `yarn.` - `containerized.` - `container.` I don't think this is helpful for making the system easy to configure. What

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-01 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2177 I addressed all comments. It seems to me that the configuration parameters for YARN are overly complicated now because they are separated in resource manager and YARN now. --- If your project is s

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-06-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2177 Good changes @rmetzger. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-06-29 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2177 Thanks for updating the documentation! I've made some suggestions regarding the names of the new configuration keys. --- If your project is set up for it, you can reply to this email and have your reply