Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2307
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2307
Please don't spend your time to write an actual test for this; for this
change it is not necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user aditivin commented on the issue:
https://github.com/apache/flink/pull/2307
Thanks @nssalian , @zentol - I'll keep the points in mind for next time.
I will try testing the logging and update this thread. Also, I've enabled
travis in my repository :)
---
If your pr
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2307
+1 to merge.
Just for future considerations: The Flink community uses rebasing instead
of merging branches to avoid these pesky merge commits. :)
---
If your project is set up for it, you ca
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2307
Hi @aditivin , welcome to the community. Thank you for the PR as well.
A few suggestions:
1) Upon opening a PR, it is best to add more information regarding testing
or even checks that you ha
