[GitHub] flink issue #2313: [FLINK-4273] Modify JobClient to attach to running jobs

2016-08-25 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2313 Thanks for helpful review @tillrohrmann and @rmetzger. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] flink issue #2313: [FLINK-4273] Modify JobClient to attach to running jobs

2016-08-25 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2313 Rebased to the changes on master. Merging after tests pass again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #2313: [FLINK-4273] Modify JobClient to attach to running jobs

2016-08-23 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2313 Merging this if there are no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] flink issue #2313: [FLINK-4273] Modify JobClient to attach to running jobs

2016-08-22 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2313 Updated according to our comment discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] flink issue #2313: [FLINK-4273] Modify JobClient to attach to running jobs

2016-08-19 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2313 I've made the last changes concerning the lazy reconstruction of the class loader we discussed. Rebased to master. Should be good to go now. --- If your project is set up for it, you can reply to this

[GitHub] flink issue #2313: [FLINK-4273] Modify JobClient to attach to running jobs

2016-08-19 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2313 @tillrohrmann Pinging the actor now to check if it is still alive. Also added another test case for that. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #2313: [FLINK-4273] Modify JobClient to attach to running jobs

2016-08-19 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2313 @tillrohrmann I've refactored the JobClientActor to include the common code in `JobClientActorBase` and have implementations for submitting/attaching in `JobSubmissionClientActor` and `JobAttachmentClien

[GitHub] flink issue #2313: [FLINK-4273] Modify JobClient to attach to running jobs

2016-08-19 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2313 Thanks for the review @tillrohrmann. Yes, the plan is to have a `JobClient` API class (the existing JobClient class will be renamed) which uses the SubmissionContext to supervise submitted jobs or attach

[GitHub] flink issue #2313: [FLINK-4273] Modify JobClient to attach to running jobs

2016-08-18 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2313 Good work @mxm. I made some minor comments inline. Just for my own clarification: Is it still planned to have a new kind of `JobClient` which is bound to a specific job and which can be

[GitHub] flink issue #2313: [FLINK-4273] Modify JobClient to attach to running jobs

2016-08-15 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2313 I did a quick pass over the code. I think this change needs another review by our Actor expert @tillrohrmann ;) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2313: [FLINK-4273] Modify JobClient to attach to running jobs

2016-08-12 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2313 CC @rmetzger @tillrohrmann Could you please take a look? I would like to merge this. Tests are passing: https://travis-ci.org/mxm/flink/builds/151653198 --- If your project is set up for it, you can rep