[GitHub] flink issue #2354: [FLINK-4366] Enforce parallelism=1 For AllWindowedStream

2016-08-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2354 Have to rerun tests on this one. The Scala API completeness check failed, so I had to adjust it. Will merge pending successful tests... --- If your project is set up for it, you can reply to

[GitHub] flink issue #2354: [FLINK-4366] Enforce parallelism=1 For AllWindowedStream

2016-08-13 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2354 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] flink issue #2354: [FLINK-4366] Enforce parallelism=1 For AllWindowedStream

2016-08-12 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2354 Yes, this is good, thanks! +1 to merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2354: [FLINK-4366] Enforce parallelism=1 For AllWindowedStream

2016-08-12 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2354 IMHO this looks good to merge now. 👍 @StephanEwen what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] flink issue #2354: [FLINK-4366] Enforce parallelism=1 For AllWindowedStream

2016-08-12 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2354 Hi @aljoscha @StephanEwen , I add a `forceNonParallel` method to `SingleOutputStreamOperator`. I think subclassing SingleOutputStreamOperator is a little unnecessary. --- If your project is set up

[GitHub] flink issue #2354: [FLINK-4366] Enforce parallelism=1 For AllWindowedStream

2016-08-11 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2354 Something like `NonParallelSingleOutputStreamOperator` but that's quite a mouthful. (`SingleOutputStreamOperator` is already too long for my taste ...). Or maybe `NonParallelStreamOperator`.

[GitHub] flink issue #2354: [FLINK-4366] Enforce parallelism=1 For AllWindowedStream

2016-08-11 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2354 Thanks for advice. Do you have any ideas about the subclass's naming. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] flink issue #2354: [FLINK-4366] Enforce parallelism=1 For AllWindowedStream

2016-08-11 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2354 I agree with Aljoscha, there may be more operators that need to constrain the parallelism. So a more generic solution would be good. --- If your project is set up for it, you can reply to

[GitHub] flink issue #2354: [FLINK-4366] Enforce parallelism=1 For AllWindowedStream

2016-08-11 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2354 Hi, thanks for tackling this. I think the way to go about this is by subclassing `SingleOutputStreamOperator` and overriding `setParallelism` there. --- If your project is set up for it, you ca