[GitHub] flink issue #2409: FLINK-4437 Lock evasion around lastTriggeredCheckpoint ma...

2016-08-25 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2409 @tedyu Should we close this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] flink issue #2409: FLINK-4437 Lock evasion around lastTriggeredCheckpoint ma...

2016-08-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2409 @tedyu No problem, happens to everyone. I actually took your code and extended it a bit. Merged in 4da40bcb9ea01cb0c5e6fd0d7472dc09397f648e --- If your project is set up for it, you can

[GitHub] flink issue #2409: FLINK-4437 Lock evasion around lastTriggeredCheckpoint ma...

2016-08-24 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/2409 I ran test suite which patch which failed here: ``` Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 201.106 sec <<< FAILURE! - in org.apache.flink.runtime.jobmanager.TaskManager

[GitHub] flink issue #2409: FLINK-4437 Lock evasion around lastTriggeredCheckpoint ma...

2016-08-24 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/2409 ``` Executing Maven: -B -f /home/jenkins/jenkins-slave/workspace/flink-github-ci/pom.xml -Dmaven.repo.local=/home/jenkins/jenkins-slave/maven-repositories/1 clean install -Dflink.forkCount=1C

[GitHub] flink issue #2409: FLINK-4437 Lock evasion around lastTriggeredCheckpoint ma...

2016-08-24 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/2409 What's the command line for running EventTimeWindowCheckpointingITCase alone ? I tried 'mvn test -Dtest=EventTimeWindowCheckpointingITCase' which didn't work. Thanks --- If your pro

[GitHub] flink issue #2409: FLINK-4437 Lock evasion around lastTriggeredCheckpoint ma...

2016-08-24 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/2409 Pardon. See if the current formation is the same as your reproduction. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] flink issue #2409: FLINK-4437 Lock evasion around lastTriggeredCheckpoint ma...

2016-08-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2409 Have to step back. This pull request is completely broken: It does not compile and after fixing this the build fails with checkstyle errors. I would suggest to close it, I have actually r

[GitHub] flink issue #2409: FLINK-4437 Lock evasion around lastTriggeredCheckpoint ma...

2016-08-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2409 Will merge this and remove redundant comments/code... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2409: FLINK-4437 Lock evasion around lastTriggeredCheckpoint ma...

2016-08-23 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2409 If the lock scope is going to be moved for the entire triggerCheckpoint() method then `// since we released the lock in the meantime, we need to re-check /