[GitHub] flink issue #2421: FLINK-4482 numUnsuccessfulCheckpointsTriggers is accessed...

2016-09-23 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2421 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] flink issue #2421: FLINK-4482 numUnsuccessfulCheckpointsTriggers is accessed...

2016-09-01 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2421 Two minor comments, otherwise +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #2421: FLINK-4482 numUnsuccessfulCheckpointsTriggers is accessed...

2016-08-31 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/2421 The test failure in flink-mesos is unrelated to the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] flink issue #2421: FLINK-4482 numUnsuccessfulCheckpointsTriggers is accessed...

2016-08-31 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2421 I think it would be good to use the `triggerLock` only within the `triggerCheckpoint(...)` method. The access to `numUnsuccessfulCheckpointsTriggers` is not super critical, it is merely