[GitHub] flink issue #2422: FLINK-4499: [WIP] Introduce findbugs maven plugin

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2422 @smarthi, could you please close this PR, now that we have added spotbugs support? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #2422: FLINK-4499: [WIP] Introduce findbugs maven plugin

Github user tedyu commented on the issue: https://github.com/apache/flink/pull/2422 Hadoop has switched to spotbugs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] flink issue #2422: FLINK-4499: [WIP] Introduce findbugs maven plugin

Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2422 We would need INFRA to enable a daily cron build for Flink. How will we use FindBugs (which may be dead)? Is a goal to export the site artifacts to S3? --- If your project is set up for it, you ca

[GitHub] flink issue #2422: FLINK-4499: [WIP] Introduce findbugs maven plugin

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2422 When would `TRAVIS_EVENT_TYPE=cron` be set? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] flink issue #2422: FLINK-4499: [WIP] Introduce findbugs maven plugin

Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2422 @smarthi are you still able to work on this PR? We could enable in a profile when `TRAVIS_EVENT_TYPE=cron` is set in the [environment](https://docs.travis-ci.com/user/environment-variables/). ---

[GitHub] flink issue #2422: FLINK-4499: [WIP] Introduce findbugs maven plugin

Github user uce commented on the issue: https://github.com/apache/flink/pull/2422 I think that the increased build times are a blocker for executing this with every CI run. Maybe this could become something that we execute nightly instead? Not ideal, but better than nothing. --- If

[GitHub] flink issue #2422: FLINK-4499: [WIP] Introduce findbugs maven plugin

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2422 Does the runtime depend on the set of activated rules? If yes, should we start with a very small set of rules that fail the build when triggered? --- If your project is set up for it, you can re

[GitHub] flink issue #2422: FLINK-4499: [WIP] Introduce findbugs maven plugin

Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2422 I've compared the build time of the pull request with a recent build on master, and it seems that the impact on the build time is pretty big (right is with findbugs): ![image](https://cloud.git

[GitHub] flink issue #2422: FLINK-4499: [WIP] Introduce findbugs maven plugin

Github user smarthi commented on the issue: https://github.com/apache/flink/pull/2422 Sure. I tried to exclude the most obvious false negatives but didn't go to the full extent. Hopefully this is a good place to start. --- If your project is set up for it, you can reply to this email

[GitHub] flink issue #2422: FLINK-4499: [WIP] Introduce findbugs maven plugin

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2422 /cc @rmetzger FYI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] flink issue #2422: FLINK-4499: [WIP] Introduce findbugs maven plugin

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2422 Cool, thanks! The changes in the code look good. Give us a bit of time to play with the build and the findbugs output to get a better feeling for this... --- If your project is set up f