Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/2768
Close the pull request because the state descriptor now is refactored with
the introduction of composited serializers (See
[FLINK-5790](https://issues.apache.org/jira/browse/FLINK-5790)).
---
I
Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/2768
@aljoscha That way, it's very confusing that a `ReadableState` is not a
`State`. Hence I made `State` read-only and introduced the `UpdatableState`
interface who extends `State` with the method
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2768
In fact, my original suggestion was to add a new interface `ReadableState`:
```
interface ReadableState {
T get();
}
```
and leave all the existing interfaces as they ar
Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/2768
@StephanEwen Thanks a lot for your comments.
**Removing `clear()` from `State`**
This change is suggested by @aljoscha who wants to let broadcast states
share the same interfac
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2768
I posted a rebased version of the state descriptor refactoring here: #3243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2768
Update: Just saw that you already did the migration support.
Will merge the `StateDescriptor` refactoring. Let's discuss the other two
types of changes separately.
---
If your project i
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2768
Hi @shixiaogang !
I went through this pull request and below are a few thoughts. The pull
request changes many things together. Some can work, and for others I would
suggest to do it dif
Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/2768
Despite the changes in the state descriptors, the Flink jobs can restore
from old versioned snapshots now.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/2768
I rebased the branch to resolve the conflicts with the master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2768
Thanks for updating, @shixiaogang. I'll look at this today!
For the change to reducing state it would be better to have this as a
separate issue/commit/PR. @fhueske you already opened an iss
Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/2768
I moved default value from `SimpleStateDescriptor` to
`ValueStateDescriptor`. Now only `ValueStateDescriptor`s have default values.
The serialization methods may contain some duplicated code, bu
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2768
@shixiaogang you can also do that, but then the machinery in
`SimpleStateDescriptor` is only used by `ValueStateDescriptor` because this is
really the only descriptor that has a default value. (In m
Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/2768
Oh... I added another field to make the code more clear, but I did not
notice the serialization problem. Thanks very much for your reminder.
Your solution does work though the concept of
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2768
@shixiaogang Thanks for the swift update! The changes look very good now
though I found one last thing that could be problematic. This is changing the
behaviour of `FoldingState` when it comes to th
Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/2768
@aljoscha Thanks for your review. I have updated the PR according to your
suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
15 matches
Mail list logo
