[GitHub] flink issue #2811: [FLINK-4541] Support for SQL NOT IN operator

2016-11-24 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/flink/pull/2811 Sure, I will do it tomorrow :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2811: [FLINK-4541] Support for SQL NOT IN operator

2016-11-24 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2811 It's true, the requirements of this issue have evolved quite a bit and we should adapt the JIRA issue for that ;-) +1 for creating an issue to support arbitrary inner joins with a single row inpu

[GitHub] flink issue #2811: [FLINK-4541] Support for SQL NOT IN operator

2016-11-24 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/flink/pull/2811 I think, that calling a JoinFunction inside a RichMapRunner make sence. I would also prefer not to touch the code generation if it's possible. But shouldn't we separate the support of all

[GitHub] flink issue #2811: [FLINK-4541] Support for SQL NOT IN operator

2016-11-23 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/flink/pull/2811 Hi, Fabian. I've made all the corrections. One thing I didn't understand - are we going to allow the case of !joinCondition.isEqui in DataSetSingleRowCrossRule? I also added

[GitHub] flink issue #2811: [FLINK-4541] Support for SQL NOT IN operator

2016-11-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2811 Great! Looking forward to an update :-) Thanks, Fabian --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] flink issue #2811: [FLINK-4541] Support for SQL NOT IN operator

2016-11-18 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/flink/pull/2811 Thanks, Fabian. It's my mistake that I used a cross function. I will try to make the same with a map function. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #2811: [FLINK-4541] Support for SQL NOT IN operator

2016-11-17 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2811 Thanks for the pull request @AlexanderShoshin! The overall approach is good. We need to fix a few things in the optimizer rule and I would like to use a `Map` instead of a `Cross` to execute the `Dat