Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3035
I pushed a fix for that to master in
e7cda75b8594417559d6aac6229b5893f5459f0f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user BrainLogic commented on the issue:
https://github.com/apache/flink/pull/3035
I caught yours idea and together with the argument which I mentioned above
- users will not extensively use 8 version of kafka connector, I agree with
this proposal.
Let me finish this jira,
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3035
I this case, the exception would not be logged, true.
It is a very rare corner case that should not affect correctness, and not
really distinguishable from the case where an exception is
Github user BrainLogic commented on the issue:
https://github.com/apache/flink/pull/3035
Distributed systems and multithreading environments make us think in term
of logical clock, like Lamport clock, step by step:
Thread1 - fetcher is running `running = true`
Thread2 performs
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3035
Quick question: I am not sure if this scenario can happen like that:
> But in this approach an unlikely bug will be still occurred:
zkHandler.prepareAndCommitOffsets(offsets); throws
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3035
@BrainLogic I'll incorporate your comment into a followup commit...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user BrainLogic commented on the issue:
https://github.com/apache/flink/pull/3035
Thanks for help and explanation.
But in this approach an unlikely bug will be still occurred:
`zkHandler.prepareAndCommitOffsets(offsets);` throws important exception
when running is true
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3035
Thank you for picking this up @StephanEwen! I've taken a look at your
approach in the local branch, +1 to the approach.
---
If your project is set up for it, you can reply to this email and have
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3035
Bit of background how the error happens:
- The test throws a `SuccessException`
- While being in the finally clause and shutting down the CluratorClient,
the containing `Task` has not
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3035
I would like to pick this fix up. The exception has still occurred a few
times for me in the past, and I prefer the above outlined solution, because it
adds less locking on
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3035
I think we can take a very simple approach here. Many other parts of the
code follow the approach to tolerate exceptions thrown during cancellation, or
during asynchronous calls on closed
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3035
Hi @BrainLogic, we're still seeing this exception in tests sometimes, and
it'll be great to have this fixed soon.
Please let us know on how you'd like to proceed with the contribution,
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3035
Dropping Java 7 has not happened and there is not yet consensus in the
community, so it probably will not happen in the next weeks.
---
If your project is set up for it, you can reply to this
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3035
Regarding some of your notes:
- The exposure of the checkpoint lock through `SourceContext` is meant for
sources to atomically update their state (e.x. Kafka offsets) with record
emitting,
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3035
Thank you for working on this @BrainLogic!
First, regarding the approach proposed here:
The approach should be able to fix the `IllegalStateException` we're
encountering.
However, I
15 matches
Mail list logo
