[GitHub] flink issue #3132: [FLINK-5519] [build] scala-maven-plugin version all chang...

2017-01-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3132 Good idea to upgrade the scala plugin. But with this change, it does not define a version at all. I think it would need to be added to the "plugin management" section. --- If your project is

[GitHub] flink issue #3132: [FLINK-5519] [build] scala-maven-plugin version all chang...

2017-01-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3132 @StephanEwen There already is an entry for `scala-maven-plugin` in the plugin management section. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] flink issue #3132: [FLINK-5519] [build] scala-maven-plugin version all chang...

2017-01-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3132 Okay, good. Then I think this is probably good to merge. @rmetzger Any reservations that the upgrade to the Apache Parent POM v18 has implications on release scripts, etc? --- If yo

[GitHub] flink issue #3132: [FLINK-5519] [build] scala-maven-plugin version all chang...

2017-01-17 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3132 I think its fine (as long as we are not merging it to the 1.2 release branch) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #3132: [FLINK-5519] [build] scala-maven-plugin version all chang...

2017-01-17 Thread shijinkui
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3132 > @rmetzger Any reservations that the upgrade to the Apache Parent POM v18 has implications on release scripts, etc? @StephanEwen There's no effect to the create_release_files.sh in my opin

[GitHub] flink issue #3132: [FLINK-5519] [build] scala-maven-plugin version all chang...

2017-01-18 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3132 Looks good, thanks. merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab