Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3138
I think that is a good fix, thank you!
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3138
@zentol @StephanEwen Please help me to review this PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3138
@StephanEwen Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3138
It would be good to add the removed code back in a way that does not
conflict with powermock, like @zentol suggested.
---
If your project is set up for it, you can reply to this email and have y
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3138
@StephanEwen What should to to with this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3138
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3138
@liuyuzhong7 Would be good to know if you plan to follow up on this issue.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3138
@zentol Right, Strom LocalCluster can run in a single class without
powermock.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3138
I played around a bit with ignore pattern but couldn't get it to work.
However, moving WrapperSetupHelperTest into a separate class and replacing
the StreamingRuntimeContext mocking (which in
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3138
@StephanEwen
Only LocalCluster in storm can't workwith powermock.
And it fail to init if ignore LocalCluster by powermock in
WrapperSetupHelperTest.
So I think delete or give a n
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3138
I think the correct fix would be not to remove the code, but
- either make sure that storm classes are ignored by powermnock (add an
ignore pattern)
- rework the test such that powermo
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3138
merging, will fix the import while doing so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3138
The `org.apache.storm.LocalCluster` import can be removed as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
13 matches
Mail list logo
