Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3141
Thanks for the update @lincoln-lil!
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3141
I think it is fine to keep this small difference for now. With FLINK-5498
and FLINK-5511 these will be gone.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3141
@fhueske when I add more test cases for "outer joins" with local
predicates, I found different limitations between tableAPI and SQL, e.g.,
"SELECT c, g FROM Table3 left outer join Table5 on a = d
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3141
@fhueske thanks for your review, I'll update this pr according to your
comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3141
Great thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3141
@fhueske FLINK-5547 make sense to me, I'll update this pr today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3141
The difference between failing during validation and translation is the
code line that throws the exception. A check during validation causes an
exception on the line that is responsible for the erro
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3141
@fhueske agree with you that the check in validation phase of the Table API
is useful for failing fast( IMO, it seems no difference on user experience that
when an exception be thrown either in v
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3141
I agree with @lincoln-lil and @shaoxuan-wang, this fix should go into the
`1.1-release`, `1.2-release`, and `master` branches. We will later add support
for non-equality predicate on left/right outer
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3141
@wuchong @lincoln-lil , I do not think this is just for 1.2.0. The out join
with non equality functionality is broken on master. We should deliver this fix
to the master as well as release 1.2.
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3141
Hi, wuchong, thanks for your review. I'll switch the pr based on 1.2.0.
I think it's not necessary doing validation repeatedly both in
DataSetJoinRule.java and operators.scala, and there alrea
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3141
Hi @lincoln-lil , thank your for the PR. I think the issue is only for
1.2.0, so please create a new pull request to commit into `release-1.2`. For
`master` we will directly fix the bug.
I
12 matches
Mail list logo
