[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...

2017-01-31 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3189 Thanks for addressing my comments. Looks very good now. I'm going ahead and merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...

2017-01-27 Thread rehevkor5
Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/3189 @zentol I updated the commit: the overall job status count is now displayed in medium-width (but not small or below), and I move the job status count to the right of job start/end & duration.

[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...

2017-01-25 Thread rehevkor5
Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/3189 Thanks @uce that's helpful! Didn't think of putting screenshots in the PR. @zentol The global job state counts didn't seem like the most important thing to show when the browser is narrow,

[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...

2017-01-25 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3189 Good point. @rehevkor5 is it possible to only hide the color boxes when the browser window is very narrow? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...

2017-01-24 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3189 How come the state of tasks is no longer shown? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...

2017-01-24 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3189 Thanks for the PR. I also sometimes had the bad experience while testing that the cancel button was not visible. This change definitely solves it. I tested it and it works as expected. I made some screen