Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3394
Incorporated your feedback @StephanEwen and rebased onto the latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3394
Thanks for the thorough review @StephanEwen. I'll will pull in your commit
with the improvements.
Concerning the other points you've raised:
- I think you're right. The timeouts
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3394
I have some suggested edits on top of this (not strictly tied to the
changes here) in that commit:
https://github.com/StephanEwen/incubator-flink/commit/910de21972992d0ed80f232f3a64bf107c6819f2
