Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3486
Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3486
I think the problem is that the "random port" was below 1024, which
requires admin rights.
Can you modify the test to use port "0"? That should auto-select a free
permitted port and always
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3486
I have seen a failure on Travis with a "permission denied" exception:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/211674112/log.txt
Not sure why that only occurred in one build.
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3486
Since not merged, I've turned them around. Sorry for the carelessness :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3486
Thanks, looks good modulo a mini issue that I can fix while merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3486
@vijikarthi I've checked the [JDK
doc](http://docs.oracle.com/javase/8/docs/technotes/guides/security/StandardNames.html#ciphersuites)
and not found any notes about combination of ssl
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3486
thanks for review @vijikarthi. I will check if there are mismatch between
protocols and cipher suites and document it if any.
---
If your project is set up for it, you can reply to this
Github user vijikarthi commented on the issue:
https://github.com/apache/flink/pull/3486
I think the patch looks good. Is there a specific protocol version + cipher
suite combination sets that the user should be aware which needs to be
documented?
---
If your project is set up for
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3486
@StephanEwen I've added some test cases for testing new function and a
ITCase to prove akka cannot accept more than one protocol setting. Let me know
if there's better way to implementation
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3486
I think this is a good fix.
Is it possible to add some form of test that makes sure the config is
properly applied in all cases? What do you think about adding to the
`SSLUtilsTest` class
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3486
Thanks for the patch!
@EronWright , @vijikarthi You are probably the most knowledgeable ones
about that code, what do you think about this change?
---
If your project is set up for
11 matches
Mail list logo
