Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3567
@aljoscha i believe enough earth rotations have passed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3567
Google's style seems sensible since IntelliJ's style cannot be modeled in
Checkstyle, the import listing is folded by default, and developers will need
to load other non-default configuration setti
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
@greghogan Now I'm confused. ð
Are you suggesting we use the Google
style or switch to the default IntelliJ style?
---
If your project is set up for it, you can reply to this email and have your
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3567
@aljoscha, I likewise have no great preference for import order. I do think
it is important for the checkstyle to match IntelliJ's code style, either the
default or a provided Flink style.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
I have no preference for any style of import order. I just wanted to
mandate some order so that we don't have edit wars when people use different
IDE settings.
@greghogan Have you tried set
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
@zentol I added a section to our IDE setup Guide.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3567
Could you create or link a guide on how to configure checkstyles per module
in Intellij?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
AFAIK it's not possible to make IntelliJ pick up the checkstyle config by
itself. On my machine the setting is in the "*.iml" project file and I think we
have so far not included IDE specific projec
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3567
It would be awesome if we could make IntelliJ pick up the style config
automatically. By committing some files under ".Idea", we might be able to
do that...
On Mar 20, 2017 11:29
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3567
@aljoscha should we host the new checkstyle under tools/maven/ alongside
the existing checkstyle? There is already a ticket (FLINK-6137) to add a custom
checkstyle to flink-cep and I don't see any
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
We will need at least two: the existing checkstyle for all the other
modules and the new strict style. (We might get away with having one checkstyle
and per-module suppression files that deactivate
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3567
@aljoscha do you think we can use a single checkstyle or will this need to
be customized per module? Is this enforced by IntelliJ?
---
If your project is set up for it, you can reply to this email
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
In the ML discussion "Google code style" was repeatedly brought up
(initially by me):
https://lists.apache.org/thread.html/94c8c5186b315c58c3f8aaf536501b99e8b92ee97b0034dee295ff6a@%3Cdev.flink.apach
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3567
@StephanEwen It enforeces the following rules:
* every files has to end with a new-line
* no trailing whitespace *anywhere*
* every public/protected method/class must have a javadoc
* im
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3567
Can you describe what rules this style actually enforces?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
Thanks for reviewing! ð
And yes, the classes I removed where unused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3567
Love the checks that were enabled. They really cover most (if not all)
issues that we have to raise in reviews at the moment.
---
If your project is set up for it, you can reply to this email and hav
17 matches
Mail list logo
