[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...

2017-05-03 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3648 Thanks for your contribution @haohui and the review @StephanEwen. Changes look good to me. Merging this PR. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...

2017-04-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3648 +1 to merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...

2017-04-21 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3648 Totally Agree :-) @StephanEwen please take another look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...

2017-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3648 Good fix, thanks @haohui I was wondering - I am a trying to advocate fewer dependencies in Flink (there is always the problem of shading and conflicts) so if there is a way to do this

[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...

2017-04-03 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3648 The test failure seems unrelated. Cannot reproduce locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...

2017-03-31 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3648 The failed tests are being addressed in FLINK-6175. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this