[GitHub] flink issue #3656: [FLINK-5994][table] Add Janino to flink-dist JAR file

Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3656 Hi, @twalthr I agree with @fhueske 's suggestion, And I'll close this JIRA. tomorrow.(2017.4.9). Thanks, SunJincheng --- If your project is set up for it, you can reply to this

[GitHub] flink issue #3656: [FLINK-5994][table] Add Janino to flink-dist JAR file

Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3656 Thanks,@fhueske, I also think add `Janino` to `jar-with-dependencies` can solve the user's problem which mentioned in this JIRA.That is why at the beginning I am in this PR I did not add

[GitHub] flink issue #3656: [FLINK-5994][table] Add Janino to flink-dist JAR file

Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3656 Thanks @sunjincheng121. I think you can close this PR. I also proposed to close FLINK-5994, because I think Janino shouldn't be added to the default artifact but to the jar-with-dependencies

[GitHub] flink issue #3656: [FLINK-5994][table] Add Janino to flink-dist JAR file

Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3656 Thanks @fhueske , I had moved the PR to FLINK-6247, and think about how to deal with this JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #3656: [FLINK-5994][table] Add Janino to flink-dist JAR file

Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3656 Here's the JIRA for this PR: https://issues.apache.org/jira/browse/FLINK-6247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #3656: [FLINK-5994][table] Add Janino to flink-dist JAR file

Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3656 I will create another JIRA for this issue and assign it to you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #3656: [FLINK-5994][table] Add Janino to flink-dist JAR file

Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3656 The jar-with-dependencies should include Janino. This jar needs to include everything that is required to run flink-table, but nothing that is already included in flink-dist.jar. If I

[GitHub] flink issue #3656: [FLINK-5994][table] Add Janino to flink-dist JAR file

Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3656 Hi @fhueske In the ML: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Flink-1-2-Proper-Packaging-of-flink-table-with-SBT-td12096.html user want

[GitHub] flink issue #3656: [FLINK-5994][table] Add Janino to flink-dist JAR file

Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3656 Btw. I think this PR does not address the liked JIRA issue. This PR adds the `flink-table` jar file to the `./opt` folder. --- If your project is set up for it, you can reply to this email and

[GitHub] flink issue #3656: [FLINK-5994][table] Add Janino to flink-dist JAR file

Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3656 Hi, @twalthr @fhueske In this PR I made the following changes： 1. Keep the `flink-table_2.10-XXX.jar` clean. 2. Add a fat jar `flink-table_2.10-XXX-jar-with-dependencies.jar` which