[GitHub] flink issue #3680: [FLINK-6268] [core] Object reuse for Either type

2017-04-06 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3680 Additional changes look good as well :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3680: [FLINK-6268] [core] Object reuse for Either type

2017-04-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3680 @zentol thanks for the review. I pushed a second commit to mark the added static methods as `@Internal` and renamed from `asLeft/Right` to `obtainLeft/Right`. --- If your project is set up for

[GitHub] flink issue #3680: [FLINK-6268] [core] Object reuse for Either type

2017-04-06 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3680 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature