[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-18 Thread lingjinjiang
Github user lingjinjiang commented on the issue: https://github.com/apache/flink/pull/3711 @greghogan @zentol thanks. Can this pull request be merged or closed now ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3711 @lingjinjiang You are now the proud owner of contributor permissions and can assign issues to yourself. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3711 @fhueske can grant you Jira permissions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-17 Thread lingjinjiang
Github user lingjinjiang commented on the issue: https://github.com/apache/flink/pull/3711 @greghogan thanks for your review. I have another question, how can I assign the issue to myself ? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-16 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3711 @lingjinjiang thanks for your contribution! Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-13 Thread lingjinjiang
Github user lingjinjiang commented on the issue: https://github.com/apache/flink/pull/3711 @greghogan, thanks for your suggestion. I have changed the log message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-13 Thread lingjinjiang
Github user lingjinjiang commented on the issue: https://github.com/apache/flink/pull/3711 @greghogan , I add some comments and log the message about hbase command not found. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-12 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3711 Would it be better to replace the outer if-statement (line 312) with the test for the presence of `hbase`? And to log a message that `HBASE_CONF_DIR` is defined but `hbase` was not found so no

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-12 Thread lingjinjiang
Github user lingjinjiang commented on the issue: https://github.com/apache/flink/pull/3711 Hi @greghogan , In the config.sh, there is a if statement identifies whether HBASE_CONF_DIR is setted. If the HBASE_CONF_DIR is setted, then will use the "hbase classpath" command to add

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-12 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3711 Hi @lingjinjiang, I am not familiar with configuring HBase for Flink and we don't seem to have documentation on this. What does it mean to have `HBASE_CONF_DIR` set but not have `hbase` available?