[GitHub] flink issue #3724: [FLINK-6275] [yarn] Fix unprotected access to resourceMan...

2017-06-25 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3724 @zentol Sorry. I just forgot. I close it right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3724: [FLINK-6275] [yarn] Fix unprotected access to resourceMan...

2017-06-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3724 @zhangminglei could you close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] flink issue #3724: [FLINK-6275] [yarn] Fix unprotected access to resourceMan...

2017-05-03 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3724 @StephanEwen Thanks. I might close this PR as there is a refactor to ```YarnFlinkApplicationMasterRunner ``` by combining with ```AbstractYarnFlinkApplicationMasterRunner``` in one class. See :

[GitHub] flink issue #3724: [FLINK-6275] [yarn] Fix unprotected access to resourceMan...

2017-05-03 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3724 I think this should be done differently. The access to the resourceManager should be under the lock, but not the waiting on the termination future. Otherwise the lock is held too long. --- If y