[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-20 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3726 Yes we should create another JIRA issue. You can create it. You can also close FLINK-6130 then. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-20 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 @tillrohrmann That is right. We can close this PR surely. BTW, Should we make another jira refactoring this class and ```AbstractYarnFlinkApplicationMasterRunner ``` ? Because I watch the

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-20 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3726 @zhangminglei please refrain from pulling more and more people into the loop by directly referencing them given that this is a trivial change and that 5 people are already involved.

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-20 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 @zentol Please helps review. I am very appreciate it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-20 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 @StephanEwen Hi, How do you think of this refine ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-18 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3726 What is the problem we're trying here to solve? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 Travis sucks some time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-17 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3726 I don't think the timeout was related. We'll see from this Travis run :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 @tzulitai Hi, Could you please review my code ? I am appreciate it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-16 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 @tedyu @zentol It seems there is a problem with travis-ci test if no output within 5 mins then it will print the stacktrace and then kill the watchdog , please help to review and checkout how