Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
Cool! 1.3 here we go!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
Merging to 1.3 now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
Well we already messed with the timings of the process by extending the
feature freeze for a week, so I'm going with the next best thing which is the
order of events. (Feature freeze -> Code freeze ->
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3736
@zentol yes, and the release release 16 days from now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
According to
https://cwiki.apache.org/confluence/display/FLINK/Time-based+releases the
release of an RC happens when code-freeze is in effect.
---
If your project is set up for it, you can reply to
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3736
@zentol, perhaps "feature freeze" is better named "major feature freeze"
and next week's "code freeze" as "minor feature freeze". My understanding is
that the first cutoff is to prevent half-merged
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
@greghogan My simple answer is that its feature freeze. There has to be
some point in time where new features, regardless of size, stability etc. can't
make it into a release. My understanding is that
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3736
@zentol @StephanEwen why not also merge this into 1.3? There are literally
no modified or removed lines of code.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
Sure.
BTW, that reminds me of one thing - I need to update the project version in
my code from 1.3-SNAPSHOT to 1.4-SNAPSHOT.
---
If your project is set up for it, you can reply to this em
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3736
@bowenli86 Th good thing is that should be able to use the reporter version
1.4-SNAPSHOT also with a Flink 1.3 release, because the reporter API is quite
stable by now.
---
If your project is s
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
I can merge it sometime this week, once i found a few more things to merge
alongside it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
I see - by looking at the code, I saw Flink has switched to version
1.4-SNAPSHOT 12h ago. Getting it into 1.4 is fine, our company has a open
ticket for getting this code into Flink, and I want to
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
This won't make it into 1.3. For one the feature freeze is in effect since
today, so it is too late to merge it now.
That said it may be possible to merge it for 1.4 and maintain a separate
r
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
@zentol cool! Let me know how to get this into 1.3 :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
No, I think we addressed all issues :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
@zentol do you have any other concerns?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
@StephanEwen @zentol I've made the following changes:
1) Datadog (DD) itself has a bug of being unstable when users filter
metrics by 'host' in dashboards if 'host' is sent as tags, detail
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3736
@bowenli86 Can you build and test this? Then I would be +1 to merge it to
1.3
It would not be committer tested, but contributor tested, and it is an
optional component that is not part of Fli
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
Sorry, I'm rather busy at the moment myself due to the feature freeze and
may not be able to try this out in time.
To be honest, given that if we merge it for 1.4-SNAPSHOT the jar can be
easi
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
@StephanEwen @zentol
Hi guys, I just tested it on my machine and it works as expected. What's
your plan on this PR? I found on email thread that there'll be a feature freeze
of release 1.3 on
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3736
+1 from my side
@zentol any further comments/concerns?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
@StephanEwen @zentol I shaded okhttp3 and okio from flink-metrics-datadog.
I didn't use 'shade-flink' because I found it somehow prevents me from
building a uber jar. Let me know if it's ok to shad
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3736
I think this is starting to look very good!
Given that this introduces new libraries as dependencies (okhttp, okio),
should we pro-actively shade those away to avoid dependency conflicts?
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
@zentol any further details and suggestions on the maven-jar-plugin part?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
Green build! @zentol
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
Aha! Updated! Apparently Chrome search is case insensitive
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
In the current PR title "Flink" isn't upper-case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
Where is the title that you're referring to? This PR's title at the very
top is already "[FLINK-6013][metrics] Add Datadog HTTP metrics reporter"
(without double quote)
---
If your project is set
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
Could you change the PR title to "[FLINK-6013][metrics] Add Datadog HTTP
metrics reporter"? The comments aren't being mirrored to JIRA.
---
If your project is set up for it, you can reply to this ema
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
@zentol ready for another round. The build fails because there are a few
unrelated flake tests timing out in travis build
---
If your project is set up for it, you can reply to this email and have
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
Addressed @zentol and @StephanEwen 's comments. Ready for another round!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3736
A few more comments on this:
- Guava is so conflict heavy that should avoid using it in the framework
wherever possible. Adding a multiple MBs dependency to write
`Lists.newArrayList`
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
Addressed @zentol 's comments. Ready for another round. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
If you want to enforce a specific scope config then i would suggest to
instead ignore the configured one (which means not using
`MetricGroup#getMetricIdentifier()`) and instead extracting the variable
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
Great advice. Thanks, @zentol !
My questions to your suggestions:
1. If I make DatadogHttpReport implement MetricReporter interface, shall I
just ignore Histogram and Meter which are
36 matches
Mail list logo
