Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3738
@tzulitai You are very welcome . It is my pleasure ~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3738
Thanks @zhangminglei. LGTM!
Merging to {{master}} and {{release-1.2}} (will merge a bit later today ;)
) ..
---
If your project is set up for it, you can reply to this email and have your
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3738
@tzulitai Hi, I have updated the code. Please check it out. Thanks and
appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3738
@StephanEwen @tzulitai Thanks for telling me so useful information. I will
fix it soon enough. Very appreciate it.
---
If your project is set up for it, you can reply to this email and have
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3738
LGTM after Stephan's comment on making `mainThread` variable `volatile` is
addressed.
Could you do that @zhangminglei?
Once updated I'll proceed to merge this, thanks :)
---
If your
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3738
The `shardConsumersExecutor` variable is final. No need to make it
`volatile`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3738
@StephanEwen Shouldn't we also make ```shardConsumersExecutor``` variable
```volatile``` as well ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3738
Looks good. To make this really safe, we should actually make the
`mainThread` variable `volatile`.
---
If your project is set up for it, you can reply to this email and have your
reply appear
